Adapt FilterNavigatorBar to High Contrast Mode. #5257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the different items are properly rendered in HCM: - the items gets a button color, and have a distinct hovered style - the selected item looks selected - the separator are visible (light and dark HCM-specific version of the existing image were added) - the disabled items have full opacity and use a gray text
nchevobbe
force-pushed
the
hcm-navigator-bar
branch
from
cec6825 to
85a71a4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5257 +/- ##
=======================================
Coverage 88.62% 88.62%
=======================================
Files 308 308
Lines 28105 28105
Branches 7621 7621
=======================================
Hits 24908 24908
Misses 2983 2983
Partials 214 214 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the different items are properly rendered in HCM: